This repository was archived by the owner on Aug 21, 2024. It is now read-only.
chore(concurrency): add log messages to the concurrency module#1990
Open
avi-starkware wants to merge 1 commit intomainfrom
Open
chore(concurrency): add log messages to the concurrency module#1990avi-starkware wants to merge 1 commit intomainfrom
avi-starkware wants to merge 1 commit intomainfrom
Conversation
avi-starkware
requested review from
OriStarkware,
Yoni-Starkware,
barak-b-starkware and
noaov1
and removed request for
noaov1
avi-starkware
force-pushed
the
avi/concurrency/add-debug-messages
branch
from
c346d99 to
b87b02b
Compare
Collaborator
Author
|
Example log messages: |
avi-starkware
requested review from
OriStarkware,
Yoni-Starkware,
barak-b-starkware and
meship-starkware
and removed request for
OriStarkware,
Yoni-Starkware and
barak-b-starkware
avi-starkware
changed the title
avi-starkware
force-pushed
the
avi/concurrency/add-debug-messages
branch
from
b87b02b to
03bc0b9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1990 +/- ##
=======================================
Coverage 78.61% 78.61%
=======================================
Files 62 62
Lines 8895 8895
Branches 8895 8895
=======================================
Hits 6993 6993
Misses 1455 1455
Partials 447 447 ☔ View full report in Codecov by Sentry. |
Collaborator
Yoni-Starkware
left a comment
Yoni-Starkware
left a comment
There was a problem hiding this comment.
I don't think this should be merged into the main; it's too many prints.
You can use it until the version is stable
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @barak-b-starkware, @meship-starkware, @noaov1, and @OriStarkware)
Collaborator
Author
|
It might make better sense to add metrics for the batcher operations and individual threads. This way we will be able to monitor and debug performance without cluttering the logs. |
gswirski
pushed a commit
to reilabs/blockifier
that referenced
this pull request
Jun 26, 2024
Co-authored-by: glihm <glihm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is